Discussion:
test -z "<string>" || mkdir
Iain Hibbert
2012-08-30 10:43:07 UTC
Permalink
Hi

was looking at (various) Makefile.in; this construct in the "install"
target

test -z "$(DESTDIR)$(bindir)" || mkdir -p "$(DESTDIR)$(bindir)"

seems wrong.. surely it should just be

test -z "$(bindir)" || mkdir -p "$(DESTDIR)$(bindir)"

?

similarly with

test -z "$(DESTDIR)$(mandir)/man1" || mkdir -p "$(DESTDIR)$(mandir)/man1"

since that test can never be false anyway.. what are we testing for?

regards,
iain

Loading...